Request time in access log - #75
Open
Jancis wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, syntactically correct in the rendered NGINX config, and aligns with the stated goal of logging request duration.
Pull request overview
This PR updates the Helm chart’s NGINX configuration to enrich access logs with request duration, helping with latency troubleshooting and basic performance monitoring directly from log output.
Changes:
- Enable
real_ip_recursivein the NGINXhttpblock. - Extend the
mainlog_formatto append$request_timeto each access log line.
File summaries
| File | Description |
|---|---|
charts/simple/templates/configmap.yaml |
Updates NGINX config to enable recursive real IP parsing and add $request_time to the access log format. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.