Fix Past() to properly calculate for all-day events - #2173
Open
chrisdebian wants to merge 1 commit into
Open
Conversation
Past() unconditionally returned false for all-day events (see the FIXME), so an all-day event that had already happened was never reported as past. Google Calendar's all-day event end dates are exclusive, so an event is past once its end date's midnight is today or earlier. Adds a date-only comparison for the all-day case and tests covering single-day and multi-day events before, during, and after "today".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`Past()` unconditionally returned `false` for all-day events (per the existing `FIXME` comment), so an all-day event that had already happened was never reported as past.
Google Calendar's all-day event end dates are exclusive (a single-day event starting on the 3rd has an end date of the 4th), so an event is past once its end date's midnight is today or earlier. This adds that date-only comparison for the all-day case, plus tests covering single-day and multi-day events before, during, and after "today".
Verified with `go build`, `go vet`, `gofmt`, and `go test` on `modules/gcal`.