Add comprehensive unit tests for modules/hibp - #2165
Open
Seanstoppable wants to merge 1 commit into
Open
Conversation
- Add table-driven tests for Status, Breach, Settings, Widget content/title formatting - Add httptest-backed tests for HIBP API client covering success, empty (404), rate limiting, unauthorized/error responses, malformed JSON, and network errors - Make apiURL a variable so tests can point it at an httptest server - Fix fetchForAccount swallowing network/read errors (was returning the wrong, already-nil err variable instead of getErr/readErr) - Coverage for modules/hibp: 0% -> 94.2% - Verified with golangci-lint; fixed errcheck findings in test HTTP handlers. Remaining gofmt warnings are pre-existing repo-wide CRLF line-ending artifacts, reproducible on unrelated untouched modules, and out of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the modules/hibp (Have I Been Pwned) package, which previously had 0% test coverage.
Coverage: 0% -> 94.2%
What's tested
Notable changes
Validation