Add unit tests for modules/updown (0% -> 71% coverage) - #2164
Open
Seanstoppable wants to merge 1 commit into
Open
Add unit tests for modules/updown (0% -> 71% coverage)#2164Seanstoppable wants to merge 1 commit into
Seanstoppable wants to merge 1 commit into
Conversation
- Table-driven tests for timeSincePing, makeURL, filterChecks, contentFrom, content - httptest-based tests for getExistingChecks: success, token filtering, non-200 responses, invalid JSON, empty responses, connection errors - Convert apiURLBase from const to var to enable test server injection - Test JSON parsing of Check struct fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for the
modules/updownpackage, bringing test coverage from 0% to 71.1%.Changes
Coverage