Add unit tests for modules/pihole (0% to 92% coverage) - #2160
Open
Seanstoppable wants to merge 3 commits into
Open
Add unit tests for modules/pihole (0% to 92% coverage)#2160Seanstoppable wants to merge 3 commits into
Seanstoppable wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds table-driven and httptest-based unit tests for modules/pihole, raising statement coverage from 0% to 92%. Covers client.go, view.go, widget.go, and settings.go. Documented a pre-existing padding bug in sortMapByIntVal/sortMapByFloatVal (tests assert actual behavior since scope is coverage-only). Ran golangci-lint run ./modules/pihole/... - no real issues; remaining gofmt warnings are pre-existing CRLF artifacts unrelated to this change.