Add unit tests for modules/lunarphase (0% → 93.7% coverage) - #2159
Open
Seanstoppable wants to merge 1 commit into
Open
Add unit tests for modules/lunarphase (0% → 93.7% coverage)#2159Seanstoppable wants to merge 1 commit into
Seanstoppable wants to merge 1 commit into
Conversation
Add comprehensive table-driven tests covering: - Settings parsing (defaults and custom values) - Date format constants (dateFormat, phaseFormat) - HTTP request construction (URL path, query params, headers) - Language header propagation - Response parsing with ANSI color conversion - Error paths: connection refused, timeout, empty body - Result caching behavior (same day not re-fetched) - Navigation: NextDay, PrevDay, NextWeek, PrevWeek, Today - Boundary cases: month/year rollovers - Widget initialization and custom timeout - Disable/Enable toggle - Refresh behavior when disabled vs enabled Uses net/http/httptest to mock the wttr.in API. Adds an unexported baseURL field to Widget for test injection (defaults to production URL, no behavior change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for the
modules/lunarphasepackage, bringing statement coverage from 0% to 93.7%.Changes
widget.go: Added an unexportedbaseURLfield toWidget(defaults to"https://wttr.in") to allow HTTP endpoint injection in tests. No behavior change for production code.widget_test.go: 683 lines of table-driven tests usingnet/http/httptest.Test Coverage
NewWidgetRefreshRefreshTitlelunarPhaseNextDay/PrevDay/NextWeek/PrevWeekTodaysetDayDisableWidgetNewSettingsFromYAMLConfigTextinitializeKeyboardControlsOpenMoonPhaseWhat's Tested
dateFormat,phaseFormat)