Add unit tests for ipinfo module (0% to 82.7% coverage) - #2157
Open
Seanstoppable wants to merge 1 commit into
Open
Add unit tests for ipinfo module (0% to 82.7% coverage)#2157Seanstoppable wants to merge 1 commit into
Seanstoppable wants to merge 1 commit into
Conversation
- Add httpClient and baseURL fields to Widget for testability - Fix Authorization header format string (was corrupted asterisks) - Test successful IP data parsing and display formatting - Test Authorization header with and without token - Test User-Agent header - Test error paths: invalid JSON, connection errors - Test setResult formatting with full, empty, and partial data - Test formatableText template generation - Test protocolVersion String() and toNetwork() methods - Test newProtocolVersion parsing with valid and invalid inputs - Test NewSettingsFromYAML with defaults, tokens, and protocol versions - All tests use httptest for API mocking, table-driven where appropriate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for
modules/ipaddresses/ipinfo, bringing coverage from 0% to 82.7%.Changes
widget.gohttpClientandbaseURLfields toWidgetstruct for dependency injection in testsAuthorizationheader format string (was corrupted/non-functional)widget_test.go(new)14 test functions using
net/http/httptestand table-driven patterns:setResultwith full/empty/partial data,formatableTextString(),toNetwork(),newProtocolVersion()parsingNewSettingsFromYAMLwith defaults, token, and all protocol versionsCoverage
```n Remaining uncovered: `getMyIP()` (requires network dial), `NewWidget`/`Refresh` (require `tview.Application`).