Add unit tests for prettyweather module (0% → 75.9% coverage) - #2153
Open
Seanstoppable wants to merge 1 commit into
Open
Add unit tests for prettyweather module (0% → 75.9% coverage)#2153Seanstoppable wants to merge 1 commit into
Seanstoppable wants to merge 1 commit into
Conversation
- Add httptest-based tests for prettyWeather() method - Test request URL construction with city/unit/view parameters - Test Accept-Language and User-Agent headers - Test error paths: invalid URL, connection refused, hijacked connection - Test ANSI code processing via ASCIItoTviewColors - Test NewSettingsFromYAML with defaults and custom values - Refactor widget to use baseURL field for testability Table-driven tests throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for
modules/weatherservices/prettyweatherusingnet/http/httptestto mock the wttr.in API.Changes
widget.go: Extract hardcoded base URL into abaseURLfield on the Widget struct for testability (no behavioral change — defaults tohttps://wttr.in/)widget_test.go: Comprehensive table-driven tests covering:ASCIItoTviewColorsNewSettingsFromYAMLwith default values and custom overridesCoverage
The remaining ~24% is in
NewWidget()andRefresh()which require a fulltview.Applicationand widget rendering infrastructure.