Add unit tests for modules/nextbus (0% → 80.5% coverage) - #2152
Open
Seanstoppable wants to merge 1 commit into
Open
Seanstoppable wants to merge 1 commit into
Seanstoppable wants to merge 1 commit into
Conversation
- Add table-driven tests for strTimeToInt time formatting - Use httptest to mock NextBus JSON API responses - Test array and single-object prediction parsing - Test HTTP error, invalid JSON, and connection failure paths - Test empty predictions edge case - Test NewSettingsFromYAML with values and defaults - Test ConfigText helper output - Extract baseURL as package var to enable httptest injection
Seanstoppable
force-pushed
the
seanstoppable-nextbus-test-coverage
branch
from
July 26, 2026 06:29
cc76558 to
d78d5ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit tests for the
modules/nextbuspackage, bringing coverage from 0% to 80.5%.Changes
widget.go: ExtractbaseURLas a package-level variable to enablehttptestinjection for testingwidget_test.go(new): Comprehensive test suiteTest Coverage
strTimeToIntgetNextBusNewSettingsFromYAMLConfigTextTests Added
TestStrTimeToInt— Table-driven tests for time formatting (zero values, whole minutes, remainder seconds, non-numeric input)TestGetNextBus_ArrayResponse— Multiple predictions parsed from JSON arrayTestGetNextBus_SingleObjectResponse— Single prediction parsed from JSON objectTestGetNextBus_HTTPError— Connection reset error handlingTestGetNextBus_InvalidJSON— Malformed response bodyTestGetNextBus_InvalidPredictionRaw— Prediction field is neither object nor arrayTestGetNextBus_EmptyPredictions— Empty array edge caseTestGetNextBus_ServerDown— Unreachable serverTestSettingsDefaults— Package constantsTestNewSettingsFromYAML— Settings parsing with valuesTestNewSettingsFromYAML_Defaults— Settings parsing with empty config