-
Notifications
You must be signed in to change notification settings - Fork 275
[3.2.x] Add test case for dynamic SSL profiles #3718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgayangi
wants to merge
1
commit into
wso2:main
Choose a base branch
from
sgayangi:sgayangi-dynamic-ssl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../src/test/java/org/wso2/micro/gateway/tests/common/MockBackEndServerForMultiSSLProfiles.java
Show resolved
Hide resolved
.../src/test/java/org/wso2/micro/gateway/tests/common/MockBackEndServerForMultiSSLProfiles.java
Show resolved
Hide resolved
.../src/test/java/org/wso2/micro/gateway/tests/common/MockBackEndServerForMultiSSLProfiles.java
Show resolved
Hide resolved
.../src/test/java/org/wso2/micro/gateway/tests/common/MockBackEndServerForMultiSSLProfiles.java
Show resolved
Hide resolved
tests/src/test/java/org/wso2/micro/gateway/tests/multiSSLProfiles/MultiSSLProfilesTestCase.java
Show resolved
Hide resolved
tests/src/test/java/org/wso2/micro/gateway/tests/multiSSLProfiles/MultiSSLProfilesTestCase.java
Show resolved
Hide resolved
tests/src/test/java/org/wso2/micro/gateway/tests/multiSSLProfiles/MultiSSLProfilesTestCase.java
Show resolved
Hide resolved
tests/src/test/java/org/wso2/micro/gateway/tests/multiSSLProfiles/MultiSSLProfilesTestCase.java
Show resolved
Hide resolved
tests/src/test/java/org/wso2/micro/gateway/tests/multiSSLProfiles/MultiSSLProfilesTestCase.java
Show resolved
Hide resolved
tests/src/test/java/org/wso2/micro/gateway/tests/multiSSLProfiles/MultiSSLProfilesTestCase.java
Show resolved
Hide resolved
tests/src/test/java/org/wso2/micro/gateway/tests/multiSSLProfiles/MultiSSLProfilesTestCase.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 2 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 3 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 4 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 5 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 6 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 7 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 8 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 9 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 10 | N | Descriptive logs are already printed when tests are run. |
| #### Log Improvement Suggestion No: 11 | N | Descriptive logs are already printed when tests are run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test case for wso2/api-manager#3997