-
Notifications
You must be signed in to change notification settings - Fork 678
[robotpy] Run wpiformat on non-python files
#8362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2027
Are you sure you want to change the base?
Conversation
|
Some of the include order issues can be resolved with tweaks to the .styleguide file, but that's all getting replaced in #8350 anyway. |
For python? Thats what I meant in reference to the import order mattering. I'm sure there is a way to disable the linter check anyway, but I figured it might be more acceptable to Dustin to just run it on these (I assume) not very frequently touched c++ files |
cf29d21 to
d0959f9
Compare
d0959f9 to
fa8baab
Compare
|
|
||
|
|
||
| #include "wpi/hal/HALBase.h" | ||
| #include <semiwrap_init.hal._wpiHal.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for these since they're locally generated files they should probably be "" includes?
Offline discussion makes it seem like @virtuald might not love this, but I figured I would at least make the PR. This turns the styleguide on for the non-python robotpy files. The overwhelming amount of changes were related to whitespace, followed by some IWYU for standard library headers.
Python files are excluded because I think import order matters for some of them, and some tests cases are currently just "make sure this can be imported".
I broke it down into a a couple of commits to make the changes more ovbious
#pragma once. This allows wpiformat to get further along in the processc-style castsandsingle arg constructors should be explicituse braces for one line if statementsand collapsing nested namespaces