[wpigui] Fix PFD file dialogs not closing after window closing #5530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohowe1
changed the title
| }; | ||
|
|
||
| class file_dialog : public dialog | ||
| class file_dialog : public internal::dialog |
Member
There was a problem hiding this comment.
This change shouldn't be required?
Contributor
Author
There was a problem hiding this comment.
It isn't required, but I made the change for it to be consistent with the other dialog classes being explicit about the namespace
PeterJohnson
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when closing the wpigui window when the file dialog is open, the file dialog will remain open. This also includes samhocevar/portable-file-dialogs#91 to properly retrieve the HWND on Windows.
PFD's
killfunction does not behave on Windows with a file dialog. I don't know enough about the windows api to fix this. With the HWND fix this is kind of a non-issue as Windows will not allow interacting with the wpigui window when the file dialog is open (but still not ideal, I'm sure). Because of the way that PFD creates file dialogs on Linux and macOS, the file dialog does not prohibit interaction with the wpigui window as is normal behavior in other applications. If we want to fix this we'd probably have to change to NFD or something similar doesn't create the file dialogs how PFD does.