Fix ReferenceError: target is not defined in loadMoreUpcomingEvents#2126
Open
oduppinsjr wants to merge 1 commit intowpeventmanager:masterfrom
Open
Fix ReferenceError: target is not defined in loadMoreUpcomingEvents#2126oduppinsjr wants to merge 1 commit intowpeventmanager:masterfrom
oduppinsjr wants to merge 1 commit intowpeventmanager:masterfrom
Conversation
Fixes a JavaScript `ReferenceError: target is not defined` when using the upcoming events shortcode with "Load more" pagination. ### Steps to reproduce 1. Use the upcoming events shortcode with load-more (not full pagination). 2. Click "Load more listings" after the first page loads. 3. Browser console shows: `Uncaught ReferenceError: target is not defined` in `event-ajax-filters(.min).js` in the AJAX `success` callback for upcoming listings. ### Root cause `loadMoreUpcomingEvents` used `target` in the success handler (copied from `getEventListings`), but `target` is never defined in that function. ### What changed Replaced the invalid `target` reference with a scoped jQuery lookup on `#upcoming_event_listing` and the loader element (`#load_more_events_loader` / `.load_more_events_loader`) so the loading state is cleared without throwing. ### Files - `assets/js/event-ajax-filters.js` - `assets/js/event-ajax-filters.min.js`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a JavaScript \ReferenceError: target is not defined\ when using the upcoming events shortcode with Load more pagination.
Root cause
\loadMoreUpcomingEvents\ referenced \ arget\ in the AJAX success handler (copied from \getEventListings), but \ arget\ is never defined in that function.
What changed
Use a jQuery lookup on #upcoming_event_listing\ and the loader (#load_more_events_loader\ / .load_more_events_loader) to clear \wpem-loading\ without throwing.
Files