Add query parameter locale to Wowhead Tooltip url#1280
Open
htve wants to merge 6 commits intowowsims:masterfrom
Open
Add query parameter locale to Wowhead Tooltip url#1280htve wants to merge 6 commits intowowsims:masterfrom
htve wants to merge 6 commits intowowsims:masterfrom
Conversation
1337LutZ
reviewed
Jan 6, 2026
1337LutZ
reviewed
Jan 6, 2026
1337LutZ
reviewed
Jan 6, 2026
|
@htve We have params.set('domain', |
This comment was marked as abuse.
This comment was marked as abuse.
Ahhh I see! Yea getting the raw tooltip URL is missing it indeed |
This comment was marked as abuse.
This comment was marked as abuse.
|
@dodoels can you do a final check on this as you added the i18n feature initially 🙏 |
dodoels
reviewed
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows the tooltip to display the correct localization data