Merged
Conversation
Fix a bunch of build warnings. - ServiceBinary `%12%\csaudiork3x.sys` does not have a corresponding CopyFiles. Fix by changing `CopyFiles=13` to `CopyFiles=12` to match the ServiceBinary entry. (Also rename CopyList to CopyFiles for consistency.) - Wildcards should not be used in vcxproj files. Fix by expanding wildcards. - Various issues with macro conflicts caused by `#include <stdint.h>`. stdint.h is a great header, but the Windows SDK only provides a user-mode version of it, and that version causes conflicts with the kernel-mode headers. Fix by removing references to stdint.h and using `UINT8` as needed. - Various warnings about missing casts. Added casts or modified variable types as seemed appropriate.
There was a problem hiding this comment.
Copilot reviewed 1 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (10)
- drivers/audio/codecs/es8323/es8323.c: Language not supported
- drivers/audio/csaudiork3x/Source/Inc/Inc.vcxproj: Language not supported
- drivers/audio/csaudiork3x/Source/Main/Main.vcxproj: Language not supported
- drivers/audio/csaudiork3x/Source/Main/csaudiork3x.inx: Language not supported
- drivers/dma/pl330dma/insn.c: Language not supported
- drivers/dma/pl330dma/pl330.c: Language not supported
- drivers/gpio/rk3xgpio/rk3xgpio.vcxproj: Language not supported
- drivers/i2c/rk3xi2c/rk3xi2c.c: Language not supported
- drivers/i2c/rk3xi2c/rockchipi2c.c: Language not supported
- drivers/sd/dwcsdhc/dwcsdhc.vcxproj: Language not supported
mariobalanica
approved these changes
Feb 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bunch of build warnings.
%12%\csaudiork3x.sysdoes not have a correspondingCopyFiles. Fix by changing
CopyFiles=13toCopyFiles=12to matchthe ServiceBinary entry. (Also rename CopyList to CopyFiles for
consistency.)
wildcards.
#include <stdint.h>. stdint.h is a great header, but the WindowsSDK only provides a user-mode version of it, and that version causes
conflicts with the kernel-mode headers. Fix by removing references to
stdint.h and using
UINT8as needed.types as seemed appropriate.