chore: bump wormhole sdk to latest version - #4941
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
52bfbcf to
dfb998c
Compare
dfb998c to
883f79b
Compare
3a59efd to
d53cb93
Compare
johnsaigle
left a comment
There was a problem hiding this comment.
-
Would you be able to explain more the decision to remove the IBC relayer tests? From my understanding this is still a live path on Wormhole via Gateway/Wormchain. So, it's something we should be running in CI. I know the standard relayer was deprecated in favour of the Executor, but I'm not aware that the IBC relayer is also replaced or deprecated.
-
Also, we should be careful with removing the Terra2 tests. I don't have a full understanding of the impact but I remember Bruce flagged this when I tried to remove Terra2 things before. IMO it's worth reviewing this Issue and the related PRs to get a sense of the impact here. #4473 (comment).
-
Can you regenerate the package-lock.json file? It is missing the integrity hashes that we need in order to safely use
npm ci(see here: https://github.com/wormhole-foundation/wormhole/blob/main/CONTRIBUTING.md#working-with-node-dependencies). AFAICT this can happen if you re-generate the lockfile without first deletingnode_modules/locally.
| ); | ||
| } | ||
|
|
||
| // TODO: Convert this over to sdkv2 |
| "Gnosis": "0x0000000000000000000000000000000000000000000000000000000000000000", | ||
| "Pythnet": "0x0000000000000000000000000000000000000000000000000000000000000000", | ||
| "Xpla": "0x8f9cf727175353b17a5f574270e370776123d90fd74956ae4277962b4fdee24c", | ||
| "Btc": "0x0000000000000000000000000000000000000000000000000000000000000000", |
There was a problem hiding this comment.
Should Btc get removed?
| "Klaytn": "0x0000000000000000000000005b08ac39eaed75c0439fc750d9fe7e1f9dd0193f", | ||
| "Celo": "0x000000000000000000000000796dff6d74f3e27060b71255fe517bfb23c93eed", | ||
| "Near": "0x148410499d3fcda4dcfd68a1ebfcdddda16ab28326448d4aae4d2f0465cdfcb7", | ||
| "Moonbeam": "0x000000000000000000000000b1731c586ca89a23809861c6103f0b96b3f57d92", |
There was a problem hiding this comment.
I believe Moonbeam has shut down
| branches: | ||
| - main | ||
| paths: | ||
| - ./clients/js |
There was a problem hiding this comment.
| - ./clients/js | |
| - clients/js/** |
I'm not sure this paths value is correct. I think we need to do it from the repo root. It's worth doing a proper red-green test here to confirm
I suggested a different path but I'd recommend checking the correct syntax here as I'm not 100% my suggestion is right.
| rpc: undefined, | ||
| key: undefined, | ||
| }, | ||
| Moonbeam: { |
| "0x0000000000000000000000005b08ac39eaed75c0439fc750d9fe7e1f9dd0193f", | ||
| Celo: "0x000000000000000000000000796dff6d74f3e27060b71255fe517bfb23c93eed", | ||
| Near: "0x148410499d3fcda4dcfd68a1ebfcdddda16ab28326448d4aae4d2f0465cdfcb7", | ||
| Moonbeam: |
| try { | ||
| const outputObject = JSON.parse(stdout); | ||
|
|
||
| // Can't check the signature, sequence, or digest because they |
There was a problem hiding this comment.
You could consider checking that they are non-empty and within the expected range for their types?
e.g.
- Signature is a fixed, expected size (and probably a hex value?)
- Sequence is in the bounds of u64
- Digest is also a fixed, expected size (and probably a hex value?)
buildaction to its ownbuild-cliaction triggered when modifying its files. This should prevent from running the ci on PRs unrelated to it