Skip to content

chore: bump wormhole sdk to latest version - #4941

Open
M-Picco wants to merge 6 commits into
wormhole-foundation:mainfrom
wormholelabs-xyz:chore/worm-cli-sdk-bump
Open

chore: bump wormhole sdk to latest version#4941
M-Picco wants to merge 6 commits into
wormhole-foundation:mainfrom
wormholelabs-xyz:chore/worm-cli-sdk-bump

Conversation

@M-Picco

@M-Picco M-Picco commented Aug 10, 2026

Copy link
Copy Markdown
Contributor
  • Clean up deprecated chains' code
  • Move cli related logic from build action to its own build-cli action triggered when modifying its files. This should prevent from running the ci on PRs unrelated to it

@socket-security

socket-security Bot commented Aug 10, 2026

Copy link
Copy Markdown

@socket-security

socket-security Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm @injectivelabs/core-proto-ts-v2 is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: clients/js/package-lock.jsonnpm/@injectivelabs/sdk-ts@1.20.34npm/@injectivelabs/core-proto-ts-v2@1.20.3

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@injectivelabs/core-proto-ts-v2@1.20.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm stream-json is 90.0% likely obfuscated

Confidence: 0.90

Location: Package overview

From: clients/js/package-lock.jsonnpm/@certusone/wormhole-sdk@0.10.18npm/@solana/web3.js@1.98.4npm/stream-json@1.9.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/stream-json@1.9.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@M-Picco
M-Picco force-pushed the chore/worm-cli-sdk-bump branch from 52bfbcf to dfb998c Compare August 11, 2026 19:48
@M-Picco
M-Picco force-pushed the chore/worm-cli-sdk-bump branch from dfb998c to 883f79b Compare August 12, 2026 17:16
@M-Picco
M-Picco marked this pull request as ready for review August 12, 2026 18:17

@johnsaigle johnsaigle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Would you be able to explain more the decision to remove the IBC relayer tests? From my understanding this is still a live path on Wormhole via Gateway/Wormchain. So, it's something we should be running in CI. I know the standard relayer was deprecated in favour of the Executor, but I'm not aware that the IBC relayer is also replaced or deprecated.

  • Also, we should be careful with removing the Terra2 tests. I don't have a full understanding of the impact but I remember Bruce flagged this when I tried to remove Terra2 things before. IMO it's worth reviewing this Issue and the related PRs to get a sense of the impact here. #4473 (comment).

  • Can you regenerate the package-lock.json file? It is missing the integrity hashes that we need in order to safely use npm ci (see here: https://github.com/wormhole-foundation/wormhole/blob/main/CONTRIBUTING.md#working-with-node-dependencies). AFAICT this can happen if you re-generate the lockfile without first deleting node_modules/ locally.

);
}

// TODO: Convert this over to sdkv2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

"Gnosis": "0x0000000000000000000000000000000000000000000000000000000000000000",
"Pythnet": "0x0000000000000000000000000000000000000000000000000000000000000000",
"Xpla": "0x8f9cf727175353b17a5f574270e370776123d90fd74956ae4277962b4fdee24c",
"Btc": "0x0000000000000000000000000000000000000000000000000000000000000000",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Btc get removed?

"Klaytn": "0x0000000000000000000000005b08ac39eaed75c0439fc750d9fe7e1f9dd0193f",
"Celo": "0x000000000000000000000000796dff6d74f3e27060b71255fe517bfb23c93eed",
"Near": "0x148410499d3fcda4dcfd68a1ebfcdddda16ab28326448d4aae4d2f0465cdfcb7",
"Moonbeam": "0x000000000000000000000000b1731c586ca89a23809861c6103f0b96b3f57d92",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe Moonbeam has shut down

branches:
- main
paths:
- ./clients/js

@johnsaigle johnsaigle Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ./clients/js
- clients/js/**

I'm not sure this paths value is correct. I think we need to do it from the repo root. It's worth doing a proper red-green test here to confirm

I suggested a different path but I'd recommend checking the correct syntax here as I'm not 100% my suggestion is right.

rpc: undefined,
key: undefined,
},
Moonbeam: {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moonbeam is gone

"0x0000000000000000000000005b08ac39eaed75c0439fc750d9fe7e1f9dd0193f",
Celo: "0x000000000000000000000000796dff6d74f3e27060b71255fe517bfb23c93eed",
Near: "0x148410499d3fcda4dcfd68a1ebfcdddda16ab28326448d4aae4d2f0465cdfcb7",
Moonbeam:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be deleted

try {
const outputObject = JSON.parse(stdout);

// Can't check the signature, sequence, or digest because they

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider checking that they are non-empty and within the expected range for their types?

e.g.

  • Signature is a fixed, expected size (and probably a hex value?)
  • Sequence is in the bounds of u64
  • Digest is also a fixed, expected size (and probably a hex value?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants