feat: upgrade SUI token bridge on testnet - #4940
Conversation
361d3c0 to
632d568
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
632d568 to
f01abeb
Compare
There was a problem hiding this comment.
Just some small comments, generally looks good, need to give the VAA building function another review. Could you confirm the following just for my understanding:
- This updated script was used to upgrade the testnet token bridge to test out the new pausing changes?
- The changes are required to use the new gRPC endpoints?
- This script will also be used for the eventual mainnet upgrade?
| * npx tsx scripts/upgrade-token-bridge-grpc.ts | ||
| * | ||
| * npx tsx scripts/upgrade-token-bridge-grpc.ts --build-only |
There was a problem hiding this comment.
Comments are referencing a non-existent file
| import { secp256k1 } from "@noble/curves/secp256k1"; | ||
| import { keccak_256 } from "@noble/hashes/sha3"; |
There was a problem hiding this comment.
This package isn't listed as an explicit direct dependency in the package.json and lock file?
| /// UpgradeContract governance VAA: module "TokenBridge", action 2, chain 21, | ||
| /// payload = 32-byte build digest. Signed by the single testnet guardian | ||
| /// (guardian set index 0). | ||
| function makeUpgradeVaa(digest: Buffer, guardianKeyHex: string): Buffer { |
There was a problem hiding this comment.
Mind adding some more inline comments to this function to explain the structure? Tbf the original file wasn't much better but it would be nice to verify what's going on by referring to a whitepaper or explaining in plain english how we're building the payload.
3 participants
No description provided.