-
Notifications
You must be signed in to change notification settings - Fork 69
feat(engine): buffered stream anchored on CannonStateNotifications + defer trie root computation on dedicated thread
#449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xOsiris
wants to merge
47
commits into
main
Choose a base branch
from
osiris/better-task-management-and-messaging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
87eed0e
feat: flashblocks p2p v2
0xForerunner f611af4
refactor
0xForerunner 1ff0377
wip
0xForerunner 94fdb5b
:wip
0xForerunner 487855d
wip
0xForerunner 7d0f608
wip
0xForerunner 78be1cd
wip
0xForerunner 31c1013
wip
0xForerunner b9eebab
wip
0xForerunner f0e94c5
wip
0xForerunner 30cafa3
cleanup
0xForerunner b2b1dea
wip
0xForerunner 0d02eb0
wip
0xForerunner 1667593
wip
0xForerunner cca37d0
fix: tests
0xForerunner 1517afb
fix: more tests
0xForerunner 4f83221
chore: clippy
0xForerunner 00e916c
fix: tests
0xForerunner 21f294a
fmt
0xForerunner 84dd7a5
refactor
0xForerunner 067b0e4
fix tests
0xForerunner 438e2fc
wip
0xForerunner bad39aa
cleanup
0xForerunner d3a2543
keep track of send
0xForerunner 50ede12
more cleanup
0xForerunner a42d45f
fix: change trusted peer behaviour
0xForerunner e5c9f19
fix: canon state tracking against pending state
0xOsiris 85379a9
wip: blocking threadpool for deferred trie
0xOsiris e803548
chore: cleanup
0xOsiris f2ed3b6
chore: add back p2p stuff
0xOsiris 899d478
feat: wire things together
0xOsiris b985445
chore: clenaup
0xOsiris 78b7fd1
chore: fmt
0xOsiris a30d12f
chore: logging
0xForerunner 1c7c3a3
chore: add auto-fmt
0xOsiris 48c6a54
Merge branch 'fr/flashblocks-p2p-v2' into osiris/better-task-manageme…
0xOsiris 7f617a0
chore: run sync on main
0xOsiris cf1d8bd
Merge branch 'osiris/better-task-management-and-messaging' of https:/…
0xOsiris 77e8342
chore: run sync
0xOsiris 410129b
fix: cleanup stream logic
0xOsiris 7f463ee
fix: cleanup + test
0xOsiris 8507b4d
fix: tasks
0xOsiris d5f590c
Apply suggestion from @0xOsiris
0xOsiris d1b3591
chore: cleanup metrics
0xOsiris 73d0c70
Merge branch 'osiris/better-task-management-and-messaging' of https:/…
0xOsiris 7a14d1b
chore: cleanup
0xOsiris b07117f
chore: auto-format
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ on: | |
| push: | ||
| tags: | ||
| - v* | ||
|
|
||
| pull_request: | ||
| env: | ||
| CARGO_TERM_COLOR: always | ||
|
|
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sync workflow accidentally triggers on all pull requests
Medium Severity
Adding bare
pull_request:tosync.ymltriggers the full sync test (60-minute timeout, builds and runs a chain sync) on every pull request. This workflow was previously scoped toworkflow_dispatch, weekly schedule, and tag pushes only. This appears to be accidentally committed and will waste CI resources on every PR.