fix: return correct flashblock index in check_for_prestate #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandromazza98
requested review from
0xForerunner,
0xOsiris,
Dzejkop,
karankurbur and
murph
as code owners
| acc.base = next.flashblock.base; | ||
| } | ||
|
|
||
| acc.index = next.flashblock.index; |
Contributor
Author
There was a problem hiding this comment.
this modification here is the one to review carefully. It's not mentioned in the audit
0xOsiris
approved these changes
Nov 14, 2025
Contributor
0xForerunner
left a comment
0xForerunner
left a comment
There was a problem hiding this comment.
Looks good. I think maybe we should get rid of flashblocks reduce. Seems a bit unnatural.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/worldcoin/issue/PROTO-3181/low-incorrect-block-index-returned-when-prestate-exists-from-p2p
Important Note
Please note that nethermind audit doesn't mention the fact that we're not updating the index in the
Flashblock::reducefn, but I think that's a bug too and I fixed it in this PR too. Review this carefully because I may be missing something.