fix(proofs): reproducibly build SP1 worker ELFs - #1037
Open
Kemperino wants to merge 8 commits into
Open
Conversation
Kemperino
requested review from
0xForerunner,
0xOsiris,
Dzejkop,
alessandromazza98,
cichaczem,
karankurbur,
kilianglas,
murph and
piohei
as code owners
August 12, 2026 12:48
Contributor
Benchmark ResultsBase and PR measured on the same runner in the same workflow run.
Raw
|
0xOsiris
requested changes
Aug 12, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0xOsiris
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Changes how production SP1 guest ELFs and on-chain vkeys are built and verified—governance-critical proof measurements. A build or pin mistake could ship a worker whose embedded ELFs diverge from committed
vkeys.json.Overview
Makes the production SP1 worker embed guest ELFs from a digest-pinned SP1 image and canonical
/root/programlayout, so on-chain vkeys no longer drift from host-path-dependent local builds.Dockerfile.proveradds a dedicatedsp1-workertarget: guests are built once insp1-guests, copied into the host builder withSP1_SKIP_PROGRAM_BUILD=true, then checked againstvkeys.jsonboth as intermediate ELF hashes and viaworld-chain-proof-sp1-worker vkeys --checkon the linked binary. The genericfinaltarget now refuses to build the SP1 worker.Also pins the SP1 image by digest in
build.rs, adds sharedembedded_vkey_manifesthelpers plus the workervkeyssubcommand, and wires CI/docker-proof.ymlto the new target (with QEMU on arm64 for the amd64 guest compiler).Reviewed by Cursor Bugbot for commit 8fc37a1. Configure here.