-
Notifications
You must be signed in to change notification settings - Fork 19
Overhaul: Bump elixir implementation and add comprehensive code coverage. #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hydepwns
wants to merge
18
commits into
workos:main
Choose a base branch
from
Hydepwns:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hydepwns
commented
May 14, 2025
- Expanded @moduledoc for WorkOS.Organizations with a clear overview and comprehensive usage examples. - Clarified docstrings for function parameters. - No functional changes.
…les - Expanded @moduledoc for WorkOS.Organizations with a clear overview and comprehensive usage examples. - Clarified docstrings for function parameters. - No functional changes.
…ameter validation - Added tests for API error responses, missing required parameters, and empty list handling in WorkOS.Organizations. - Updated create_organization and update_organization to return {:error, :missing_name} if :name is missing, instead of raising. - Improves robustness and user experience for the Organizations API.
…ing, docs, and coverage
…ng behaviour/callbacks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request overhauls the Elixir SDK documentation and CI workflow configurations with expanded module documentation and improved code coverage reporting.
- Added a Codecov badge to README.md for enhanced visibility of test coverage.
- Updated CI workflow: switched branch reference from master to main, bumped the Ubuntu runner version, and integrated new Codecov actions for uploading test results and coverage reports.
Reviewed Changes
Copilot reviewed 20 out of 38 changed files in this pull request and generated no comments.
File | Description |
---|---|
README.md | Added a Codecov badge and removed a stray header line. |
.github/workflows/main.yml | Updated CI configurations including Ubuntu version bump and Codecov upload steps. |
Files not reviewed (18)
- lib/workos/castable.ex: Language not supported
- lib/workos/client.ex: Language not supported
- lib/workos/organizations.ex: Language not supported
- lib/workos/sso.ex: Language not supported
- lib/workos/user_management/multi_factor/sms.ex: Language not supported
- lib/workos/user_management/multi_factor/totp.ex: Language not supported
- lib/workos/user_management/organization_membership.ex: Language not supported
- lib/workos/user_management/reset_password.ex: Language not supported
- lib/workos/user_management/user.ex: Language not supported
- mix.exs: Language not supported
- test/support/audit_logs_client_mock.ex: Language not supported
- test/support/directory_sync_client_mock.ex: Language not supported
- test/support/directory_sync_client_mock_test.exs: Language not supported
- test/support/events_client_mock.ex: Language not supported
- test/support/organization_domains_client_mock.ex: Language not supported
- test/support/organizations_client_mock.ex: Language not supported
- test/support/passwordless_client_mock.ex: Language not supported
- test/support/portal_client_mock.ex: Language not supported
Comments suppressed due to low confidence (1)
README.md:37
- [nitpick] The removal of the stray '###' markdown header just above the SDK Versioning section may have been unintentional. Please confirm if this deletion was deliberate.
## SDK Versioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.