Skip to content

Fix query error in WfoSubscriptionNoteEdit by using existing data #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tjeerddie
Copy link
Contributor

@tjeerddie tjeerddie commented Jun 23, 2025

the component was re-fetching data without query variables which resulted in query errors const endpointName = useQuery().endpointName; but was also confused why the data is refetched

  • change WfoSubscriptionNoteEdit to use existing data
  • clean WfoSubscriptionsList and move the subscription list fetch above the table columns so the list can be used in WfoSubscriptionNoteEdit. (also cleaned up the html)
  • change subscriptionResultMappers to work with response or undefined and returns empty list when undefined.

Copy link

changeset-bot bot commented Jun 23, 2025

⚠️ No Changeset found

Latest commit: 4a10171

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tjeerddie tjeerddie force-pushed the fix-subscription-list-query branch from ec2c9ba to 312e484 Compare June 23, 2025 12:49
the component was re-fetching data without query variables which resulted in query errors.

- change WfoSubscriptionNoteEdit to use existing data
- clean WfoSubscriptionsList and move the subscription list fetch above the table columns so the list can be used in WfoSubscriptionNoteEdit.
- change subscriptionResultMappers to work with response or undefined and returns empty list when undefined.
@tjeerddie tjeerddie force-pushed the fix-subscription-list-query branch from 312e484 to 4a10171 Compare June 23, 2025 12:51
Copy link
Contributor

@Georgi2704 Georgi2704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants