1904 lib create port #1973
1904 lib create port #1973
Conversation
|
DutchBen
force-pushed
the
1904-lib-create-port
branch
from
6b6af52 to
799c24d
Compare
| import type { WfoTheme } from '@/hooks'; | ||
| import { useWithOrchestratorTheme } from '@/hooks'; | ||
|
|
||
| const getFormFieldsBaseStyle = ({ theme }: WfoTheme) => { |
There was a problem hiding this comment.
Consider to move this one to its own styles file. Either one specific for this field or just one for all fields
| @@ -130,6 +130,7 @@ | |||
| "nodePort": { | |||
| "loadingNodes": "Loading Node subscriptions...", | |||
| "loadingPorts": "Loading IMS ports...", | |||
| "noPorts": "NO PORTS FOUND FOR THIS NODE", | |||
There was a problem hiding this comment.
Is the screaming needed?
| @@ -27,7 +27,16 @@ import { FormValidationError } from '@/types'; | |||
| import { Footer } from './Footer'; | |||
| import { Header } from './Header'; | |||
| import { Row } from './Row'; | |||
| import { Checkbox, Divider, Label, Summary, Text, TextArea } from './fields'; | |||
| import { | |||
There was a problem hiding this comment.
Do not forget the changeset file in the PR
Shouldn't be merged before Contact persons component is merged from @Georgi2704's work