Skip to content

Fix some console warnings about aria-labels #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix some console warnings about aria-labels #1101

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c95b9
Fix some console warnings about aria-labels
May 14, 2024
8622836
Add changeset
May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/orchestrator-ui-components/src/components/WfoDiff/WfoDiff.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,17 +95,24 @@ const WfoDiff: FC<WfoDiffProps> = ({ oldText, newText, syntax }) => {
: 'continuityWithin'
}
onClick={() => setShowSplit(!showSplit)}
aria-label={t(
showSplit
? 'continuityAboveBelow'
: 'continuityWithin',
)}
/>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
size={'s'}
iconType={showFull ? 'fullScreenExit' : 'fullScreen'}
onClick={() => setShowFull(!showFull)}
aria-label={t(
showFull ? 'fullScreenExit' : 'fullScreen',
)}
/>
</EuiFlexItem>
</EuiFlexGroup>

<EuiSpacer />
<Diff
css={diffStyle}
Expand Down
1 change: 1 addition & 0 deletions ...hestrator-ui-components/src/components/WfoTable/WfoTableWithFilter/WfoTableWithFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export const WfoTableWithFilter = <T extends object>({
onClick={() => setShowSearchModal(true)}
iconSize={'xl'}
iconType={'iInCircle'}
aria-label={t('searchModalTitle')}
/>
</EuiFlexItem>
<EuiButton onClick={() => setShowSettingsModal(true)}>
Expand Down
6 changes: 5 additions & 1 deletion packages/orchestrator-ui-components/src/messages/en-GB.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,11 @@
"traceback": "Traceback"
},
"delta": {
"title": "Subscription delta"
"title": "Subscription delta",
"fullScreenExit": "Exit full-screen mode",
"fullScreen": "Full-screen mode",
"continuityAboveBelow": "Continuity above below",
"continuityWithin": "Continuity within"
}
},
"workflows": {
Expand Down
6 changes: 5 additions & 1 deletion packages/orchestrator-ui-components/src/messages/nl-NL.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,11 @@
"traceback": "Traceback"
},
"delta": {
"title": "Subscription delta"
"title": "Subscription delta",
"fullScreenExit": "Exit full-screen mode",
"fullScreen": "Full-screen mode",
"continuityAboveBelow": "Continuity above below",
"continuityWithin": "Continuity within"
}
},
"workflows": {
Expand Down
6 changes: 5 additions & 1 deletion packages/orchestrator-ui-components/src/pages/processes/WfoProductInformationWithLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ export const WfoProductInformationWithLink = ({
{showWorkflowInformationLink && (
<EuiToolTip content={t('openWorkflowTaskInfo')}>
<a href={docsUrl} target="_blank">
<EuiButtonIcon iconSize={'l'} iconType={'iInCircle'} />
<EuiButtonIcon
iconSize={'l'}
iconType={'iInCircle'}
aria-label={t('openWorkflowTaskInfo')}
/>
</a>
</EuiToolTip>
)}
Expand Down