Change scheduler to apscheduler #1024
Conversation
tjeerddie
force-pushed
the
909-change-to-apscheduler
branch
from
cd7f1de to
ec2aa44
Compare
CodSpeed Performance ReportMerging #1024 will not alter performanceComparing 🎉 Hooray!
|
tjeerddie
force-pushed
the
909-change-to-apscheduler
branch
4 times, most recently
from
c2b5da8 to
09e0590
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 84.93% 85.09% +0.16%
==========================================
Files 214 217 +3
Lines 10408 10481 +73
Branches 1020 1003 -17
==========================================
+ Hits 8840 8919 +79
- Misses 1295 1308 +13
+ Partials 273 254 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tjeerddie
force-pushed
the
909-change-to-apscheduler
branch
6 times, most recently
from
b406470 to
5074546
Compare
tjeerddie
force-pushed
the
909-change-to-apscheduler
branch
5 times, most recently
from
de944b7 to
af4b6a8
Compare
- update cli commands. - update unit tests.
- rename scheduled jobs to scheduled tasks
tjeerddie
force-pushed
the
909-change-to-apscheduler
branch
from
af4b6a8 to
ad0f3bc
Compare
- update deprecation of `db.wrapped_database.scoped_session.close_all()` to `close_all_sessions()`.
tjeerddie
force-pushed
the
909-change-to-apscheduler
branch
from
ad0f3bc to
a2fc3f0
Compare
| if isinstance(value, (int, float)): | ||
| return -value | ||
| if isinstance(value, str): | ||
| return "".join(chr(255 - ord(c)) for c in value) |
There was a problem hiding this comment.
This is limited to ascii chars, anything beyond that raises a ValueError. Can address this by keeping the unicode points as a tuple
return tuple(-ord(c) for c in value)
| return -value | ||
| if isinstance(value, str): | ||
| return "".join(chr(255 - ord(c)) for c in value) | ||
| return value |
There was a problem hiding this comment.
Think datetime should be covered here?
| scheduler.start(paused=True) | ||
| scheduled_tasks = scheduler.get_jobs() | ||
| scheduler.shutdown(wait=False) | ||
| jobstores["default"].engine.dispose() |
There was a problem hiding this comment.
Would be good to have a utility function for this, few repetitions here and in cli module
| mock_job.args = () | ||
| mock_job.kwargs = {} | ||
|
|
||
| # mock_scheduler.start = mock.MagicMock() |
There was a problem hiding this comment.
few commented lines in file can be removed
Related: #909