refactor: prevent TTL extension on mount, add SSR guardrail, fix null/undefined round-trip#22
Merged
Conversation
…/undefined round-trip
- Skip the initial post-hydration write via a `firstRun` ref; previously every
mount re-serialized the hydrated value and reset `expiry`, silently extending
TTL indefinitely for any component that remounted before expiration
- Guard all storage access behind an SSR-safe `isBrowser` check
- Wrap cached payloads in `{ value }` so `null`/`undefined` survive round-trip
(previously indistinguishable from a cache miss)
- Move TTL unit + argument validation out of the write path; compute once at
configuration time and tighten type checks (reject NaN, Infinity, non-numbers)
- Replace `SUPPORTED_HOOKS` array with a `Set` for O(1) lookup and clearer intent
- Gate `console.warn` behind `NODE_ENV !== "production"` to silence prod noise
- Extract `dropCache` helper and reuse it from the memoized `remove()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firstRunref; previously every mount re-serialized the hydrated value and resetexpiry, silently extending TTL indefinitely for any component that remounted before expirationisBrowsercheck{ value }sonull/undefinedsurvive round-trip (previously indistinguishable from a cache miss)SUPPORTED_HOOKSarray with aSetfor O(1) lookup and clearer intentconsole.warnbehindNODE_ENV !== "production"to silence prod noisedropCachehelper and reuse it from the memoizedremove()