Do not panic on an empty entry in the repositories block - #2042
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
The tagged-repository-in-environment-repos rule indexes repo[0] on every
entry of environment.contents.repositories and buildRepositories. An empty
string entry, which is easy to produce with a stray dash in the YAML, made
the linter panic on the file it was asked to lint:
panic: runtime error: index out of range [0] with length 0
Use strings.HasPrefix instead, which is what the check means anyway.
Adds a fixture with an empty entry; it panics without the change.
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tagged-repository-in-environment-reposrule readsrepo[0]on every entry ofenvironment.contents.repositoriesandbuildRepositories. An empty string entry is easy to produce with a stray dash in the YAML, and it makes the linter panic on the very file it was asked to lint:strings.HasPrefix(repo, "@")is what the check means anyway, and it is safe on an empty string.Added a
empty-repository-entry.yamlfixture whose repositories block has one empty entry. It panics on main and passes here. The existingforbidden-repository-tagged.yamlcase still reports the tagged repository as before, so the rule itself is unchanged for real input.