Repository navigation
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #434
Scan targets checked: wolfssljni-src, wolfssljni-bugs
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: src/test/com/wolfssl/provider/jsse/test/WolfSSLTrustX509Test.java
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
There was a problem hiding this comment.
🟡 Changes recommended
Basic trust-manager LDAPS verification still considers SNI instead of exclusively verifying the peer host.
1 open finding
What changed in this PR
Adds case-insensitive endpoint identification algorithm matching for JSSE hostname verification.
Changes:
- Accepts case variants of
HTTPSandLDAPS. - Preserves rejection of unknown algorithms.
- Adds socket, engine, and trust-manager coverage.
| File | Description |
|---|---|
WolfSSLTrustX509.java |
Uses case-insensitive algorithm matching. |
WolfSSLInternalVerifyCb.java |
Updates external trust-manager verification matching. |
WolfSSLTrustX509Test.java |
Adds endpoint identification tests and corrects LDAPS test naming. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
a32d3c7 to
4d3a32c
Compare

This PR matches the
SSLParametersendpoint identification algorithm case-insensitively, as SunJSSE does. Apache HttpClient 5 sets it to"https", but wolfJSSE only accepted the exact strings"HTTPS"and"LDAPS", so the handshake failed withCertificateException: Unsupported Endpoint Identification Algorithm: https. Unknown names are still rejected.Changes
WolfSSLTrustX509andWolfSSLInternalVerifyCb: compare withequalsIgnoreCase().WolfSSLTrustX509Testtests, run over SSLSocket, SSLEngine, and a basicX509TrustManager:"ldaps"applies LDAPS rules (ignores SNI, left-most wildcard only)"HTTP"and"https "still failtestX509ExtTrustMgrSSLEngineEndpointAlgFailtotestX509ExtTrustMgrSSLEngineLDAPSIgnoresSNIFailand fixed its comments. It tests that LDAPS ignores SNI, not an unsupported algorithm.