Skip to content

Fixes for TrustX509 issuer lookup, JNI callbacks, session cache save - #428

Merged
rlm2002 merged 5 commits into
wolfSSL:masterfrom
cconlon:fenrirSept25_4
Oct 2, 2026
Merged

rlm2002 merged 5 commits into
wolfSSL:masterfrom
cconlon:fenrirSept25_4

Conversation

@cconlon

@cconlon cconlon commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

This PR includes 5 Fenrir fixes:

  • F-3917: memsaveSessionCache() only copies to the caller's array on success and within the caller-supplied size
  • F-9131: findIssuerBySignature() skips non-CA KeyStore entries unless trusted peer certs are enabled, matching CertManagerLoadCAKeyStore()
  • F-9134: verifyHostnameByType() frees its WolfSSLCertificate on every exit path
  • F-10766: MAC/encrypt callback builds the encIn ByteBuffer from encIn instead of encOut
  • F-10768: PSK callbacks zero the Java key array once native code has copied the key

@cconlon cconlon self-assigned this Sep 25, 2026
Copilot AI lite review requested due to automatic review settings September 25, 2026 20:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #428

Scan targets checked: wolfssljni-src, wolfssljni-bugs
Coverage: 3 of 9 in-scope changed file(s) opened by the reviewer; not opened: src/java/com/wolfssl/WolfSSLPskClientCallback.java, src/java/com/wolfssl/WolfSSLPskServerCallback.java, src/test/com/wolfssl/provider/jsse/test/WolfSSLParametersPskTest.java, src/test/com/wolfssl/provider/jsse/test/WolfSSLTestFactory.java, src/test/com/wolfssl/provider/jsse/test/WolfSSLTrustX509Test.java, src/test/com/wolfssl/test/WolfSSLTest.java

Fenrir result: Approved ✅

No new issues found in the changed files.

Advisory only — this automated result does not count as a GitHub approval.

Review tier: Lite

@cconlon cconlon assigned rlm2002 and unassigned cconlon Oct 1, 2026
@rlm2002
rlm2002 merged commit 091b1f7 into wolfSSL:master Oct 2, 2026
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants