-
Notifications
You must be signed in to change notification settings - Fork 885
20250731-enable-all-crypto-PQC #9052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
test "$enable_lms" = "" && enable_lms='yes,sha256-192' | ||
test "$enable_xmss" = "" && enable_xmss=yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify only?
configure.ac
Outdated
if test "$ENABLED_EXPERIMENTAL" = "yes" | ||
then | ||
test "$enable_dilithium" = "" && enable_dilithium=yes | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think nothing should be experimental after not being experimental? Customers will think its weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per SPH, the alternative was leaving it out of all-crypto entirely for now, but I'm game for just enabling it here without the experimental gate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, when you do ./configure --enable-dilithium
it works. So, should not need an experimental gate.
This PR has uncovered some substantive stuff -- mainly the RISC-V build failure, but there's also some |
…and by extension, --enable-all).
…for ENABLED_EXPERIMENTAL; wolfssl/wolfcrypt/sha512.h: add a prototype for wc_Sha512HashBlock() (only implemented in wolfcrypt/src/port/riscv/riscv-64-sha512.c); wolfcrypt/src/asn.c, wolfcrypt/src/wc_mlkem.c, wolfcrypt/src/wc_mlkem_poly.c: add casts (and fix a few type clashes) to suppress for -Wconversions.
67ee52e
to
80200c3
Compare
configure.ac
: add native PQC implementations to--enable-all-crypto
(and by extension,--enable-all
).tested with
wolfssl-multi-test.sh ... check-source-text check-configure
and a couple direct builds with and without linuxkm.note, Dilithium gated behind
$ENABLED_EXPERIMENTAL
until name conversion to ML-DSA.