-
Notifications
You must be signed in to change notification settings - Fork 5
wolfjsse netty-tests #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a Docker test image for running upstream Netty SSL tests with wolfJSSE in FIPS mode. The implementation clones Netty 4.1.115.Final, applies FIPS compatibility patches, and configures the environment to run approximately 800 SSL tests using wolfSSL example certificates.
Key changes:
- Adds build infrastructure and FIPS compatibility patch script for Netty testing
- Replaces Netty's self-signed certificates with wolfSSL example certificates
- Skips OpenSSL-specific tests and FIPS-incompatible algorithms (MD5, 3DES, weak ciphers)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| build.sh | Build script with argument parsing, Docker image validation, and build orchestration for the Netty test container |
| apply_netty_fips_fixes.sh | Comprehensive patching script that modifies Netty source for wolfJSSE FIPS compatibility - replaces certificates, reorders cipher suites, disables incompatible tests |
| Dockerfile | Multi-stage Docker build that compiles patched Netty, installs wolfSSL certificates, and creates test runner script |
| README.md | Documentation with build instructions and usage examples for running the Netty test suite |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
java/wolfssl-openjdk-fips-root/test-images/netty-tests/apply_netty_fips_fixes.sh
Outdated
Show resolved
Hide resolved
java/wolfssl-openjdk-fips-root/test-images/netty-tests/apply_netty_fips_fixes.sh
Show resolved
Hide resolved
java/wolfssl-openjdk-fips-root/test-images/netty-tests/apply_netty_fips_fixes.sh
Show resolved
Hide resolved
java/wolfssl-openjdk-fips-root/test-images/netty-tests/README.md
Outdated
Show resolved
Hide resolved
java/wolfssl-openjdk-fips-root/test-images/netty-tests/apply_netty_fips_fixes.sh
Show resolved
Hide resolved
6d9fd51 to
6fb6a7e
Compare
| sed -i '/^public class JdkSslRenegotiateTest/i @Disabled("wolfJSSE: Renegotiation not supported")' "$JDKRENEG_TEST" | ||
| fi | ||
|
|
||
| # CloseNotifyTest - may have compatibility issues with wolfJSSE close behavior |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we confirm that this CloseNotify behavior was not a bug in wolfJSSE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CloseNotifyTest failure is FIPS-specific - the test passes on non-FIPS wolfJSSE. The close_notify event sequence/timing differs in FIPS mode due to stricter handshake requirements.
| sed -i '/public void testTLSv13DisabledIfNoValidCipherSuiteConfigured(/i \ @Disabled("wolfJSSE: TLS 1.3 prioritization differs")' "$SSLENGINE_TEST" | ||
| sed -i '/public void testSupportedSignatureAlgorithms(/i \ @Disabled("wolfJSSE: Signature algorithm handling differs")' "$SSLENGINE_TEST" | ||
|
|
||
| # Session handling tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we verify that these session handling test failures are not things we need to fix in wolfJSSE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These session handling tests (testSessionCache, testSessionAfterHandshake, etc.) pass on non-FIPS wolfJSSE and only fail in fips mode.
|
When I run this following the README steps, I see the following which looks like two tests have errors: Earlier in the test log I also saw this OutOfMemoryError show up. Is this expected? |
6fb6a7e to
ef180f4
Compare
|
Fixed the 2 failing tests (cert issue) and fixed the java heap space issue. At the end of the handler test I still get "There was a timeout or other error in the fork" but I have confirmed that it is running all of the tests we haven't disabled, and this only happens during the shutdown, and it does not happen on the non fips mode. |
Add Netty SSL test image for wolfJSSE FIPS
Docker image that runs upstream Netty SSL tests with wolfJSSE in FIPS mode.
-Clones Netty 4.1.115.Final and applies FIPS compatibility patches via shell script
-Runs handler, handler-proxy, and testsuite modules (~800 tests after unsupported fips tests removed)
-Skips OpenSSL-specific tests and FIPS-incompatible algorithms (MD5, 3DES, etc)
-Uses wolfSSL example certs (fetched from GitHub during build)