Add pgBackRest v2.54 with Greenplum support.#69
Conversation
Delete info about pgBackRest v2.47 and v2.50 with Greenplum support. These are fairly old versions with Greenplum support. Starting from this commit, the repository supports the latest 2 versions of pgBackRest with Greenplum support. To build older versions of pgBackRest with Greenplum support, use manual build. The pgBackRest with Greenplum support build has been switched to meson.
There was a problem hiding this comment.
Pull request overview
This PR updates pgBackRest with Greenplum support to version 2.54 and removes support for older versions (2.47 and 2.50). The repository now maintains the latest 2 versions instead of 3, and switches to using meson-based Dockerfiles for newer versions (≥ v2.51).
Key changes:
- Add version 2.54_arenadata13 with Greenplum support
- Remove versions 2.47_arenadata4 and 2.50_arenadata4
- Implement conditional logic to use make-based or meson-based builds based on version
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates supported versions list and adds documentation for building older versions |
| Makefile | Adds version comparison logic to conditionally use Dockerfile_make or Dockerfile based on version |
| .github/workflows/build.yml | Updates matrix to use new versions and switches to meson-based Dockerfiles |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
README.md
Outdated
|
|
||
| ### Build pgBackRest < `v2.51` with Greenplum support | ||
|
|
||
| If you need to build pgBackRest with Greenplum support lower than `v2.51`, use the files [Dockerfile_make](./Dockerfile) or [Dockerfile_make.alpine](./Dockerfile_make.alpine). |
There was a problem hiding this comment.
The links to Dockerfile_make files are incorrect. The link text shows 'Dockerfile_make' but points to './Dockerfile', and 'Dockerfile_make.alpine' points to './Dockerfile_make.alpine'. The links should point to './Dockerfile_make' and './Dockerfile_make.alpine' respectively.
| If you need to build pgBackRest with Greenplum support lower than `v2.51`, use the files [Dockerfile_make](./Dockerfile) or [Dockerfile_make.alpine](./Dockerfile_make.alpine). | |
| If you need to build pgBackRest with Greenplum support lower than `v2.51`, use the files [Dockerfile_make](./Dockerfile_make) or [Dockerfile_make.alpine](./Dockerfile_make.alpine). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
README.md
Outdated
| @@ -311,6 +309,10 @@ docker pull ghcr.io/woblerr/pgbackrest:tag-gpdb-alpine | |||
| docker run --rm pgbackrest:2.52-gpdb pgbackrest help | |||
There was a problem hiding this comment.
[nitpick] The example in the documentation still references the old version 2.52-gpdb. Consider updating this to reference the newer 2.54-gpdb version to align with the PR's purpose of promoting the latest version.
| docker run --rm pgbackrest:2.52-gpdb pgbackrest help | |
| docker run --rm pgbackrest:2.54-gpdb pgbackrest help |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Delete info about pgBackRest
v2.47andv2.50with Greenplum support. These are fairly old versions with Greenplum support.Starting from this commit, the repository supports the latest
2versions of pgBackRest with Greenplum support.To build older versions of pgBackRest with Greenplum support, use manual build.
The pgBackRest with Greenplum support build has been switched to
meson.