Define global N variable in test_stltypes on the Python side
#309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the stltypes test only works by accident if the datatypes dictionary is loaded too, because that's where one can find the `gbl.N` variable that is used by the test. To avoid this dependency, define the `N` variable on the Python side instead.
Contributor
Author
|
@wlav can this be merged please? It should not be controversial, and it's a bit awkward for the build system if the |
Contributor
Author
|
Hi @wlav! Do you see any problem with this PR? |
Owner
|
In essence, yes: way in the beginning, it wasn't possible to redeclare a global variable such as N in Cling. Thus, I'd rather it be kept the same name (just "N") and pulled from Cling, so that if redeclaration fails somehow, it'll show up in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the stltypes test only works by accident if the datatypes dictionary is loaded too, because that's where one can find the
gbl.Nvariable that is used by the test. To avoid this dependency, define theNvariable on the Python side instead.Mimics the following ROOT commit:
root-project/root@1b41183