Add Expressive Code missing translations based on Astro Docs - #4160
Conversation
🦋 Changeset detectedLatest commit: f8c73fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
size-limit report 📦
|
delucis
left a comment
There was a problem hiding this comment.
Awesome! Thanks for following up on this and taking the time to figure out which ones it made sense to copy.
I only spotted one potential change, although, like you, I can’t judge the translation quality itself. But I also trust the Astro Docs process and these should definitely be better than no translation.
|
Thanks for the contribution and detailed PR description! The PR overall looks really solid. However, one thing I noticed were differences between translations of the tooltip: Expressive Code itself uses However, these two languages seem to only translate the string Russian could easily be fixed by taking over the translation string from Astro docs:
For Italian, we might want to get help from a native-speaker from Discord 🤔 |
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
|
@trueberryless Yeah, I noticed the difference. However, I don't know what the common usage is in those languages: just because a machine translation tool suggests something doesn't mean it's the expression actually used. Perhaps the concept of a "clipboard" doesn't add any value for them? But, if we think this is problematic vs falling back to English; I don't mind removing them. |
delucis
left a comment
There was a problem hiding this comment.
Thanks @ArmandPhilippot 🙌
Re: @trueberryless’s last comment — I definitely trust the human translators over machine translation, so I’m happy to accept these and can always tweak based on native speaker feedback if we get some in the future.


Description
Follow-up on withastro/docs#14460 (comment)
Expressive Code only has English and German translations built-in. Astro Docs has more translations: we should take advantage of this to upstream the missing translations to Starlight.
I only included the missing ones:
ar,de,hi,it,ja,ko,pt,zh-CN, andzh-TW.The following are not included:
es: Astro Docs / Starlight (seems identical)pl: Astro Docs / Starlight (seems identical)ru: Astro Docs / Starlight (expressiveCode.copyButtonTooltipseems different)And, I haven't checked if the translation are correct... I trust Astro Docs translators. 😅