Skip to content

i18n(ja): Update basics/astro-components.mdx #11879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 14, 2025

Conversation

anmoti
Copy link
Contributor

@anmoti anmoti commented Jun 11, 2025

Description (required)

Apply ad30681 to the Japanese version.

Related issues & labels (optional)

  • Closes #
  • Suggested label: i18n

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 11, 2025
Copy link

netlify bot commented Jun 11, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 33666a6
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/687521eca0180300084fdc58
😎 Deploy Preview https://deploy-preview-11879--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 11, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ja/basics/astro-components.mdx Localization changed, will be marked as complete. 🔄️
ja/reference/astro-syntax.mdx Localization changed, will be marked as complete.
ja/reference/directives-reference.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎈
In addition to ad30681, there seem to be some other changes in overview that have not been translated. If you are interested, you can try to translate them :)

@anmoti
Copy link
Contributor Author

anmoti commented Jun 16, 2025

@ryuapp

I checked and could not find any other changes to this file.
If you have, could you please present them?

@ryuapp
Copy link
Contributor

ryuapp commented Jun 16, 2025

That I could find was in overview, but it seems there are other changes as well: 45a1170

image

@yanthomasdev
Copy link
Member

@anmoti pinging here since this PR got stale, I'd appreciate if you could address ryu's last review when you have time!

@yanthomasdev
Copy link
Member

Thanks @anmoti, we just got a change in this file, could you also translate this part, as well? 1348bff

@anmoti
Copy link
Contributor Author

anmoti commented Jun 25, 2025

@yanthomasdev

I translated changes in 1348bff.
There was an untranslated part in reference/astro-syntax linked frombasics/astro-components, so I added and corrected the translation.
Would a different pull request be better, perhaps?

@jp-knj
Copy link
Contributor

jp-knj commented Jul 10, 2025

Hi @anmoti 👋 No rush at all. just checking in.
Do you have any plans to fix links or continue working on this PR?

Copy link
Contributor Author

@anmoti anmoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jp-knj.
Sorry, did not check CI.
Fixed the link issue and also fixed the missing link issue.

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work 💜

@yanthomasdev yanthomasdev merged commit 2bcf84e into withastro:main Jul 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants