-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
i18n(ja): Update basics/astro-components.mdx
#11879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(ja): Update basics/astro-components.mdx
#11879
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and could not find any other changes to this file. |
That I could find was in overview, but it seems there are other changes as well: 45a1170 |
@anmoti pinging here since this PR got stale, I'd appreciate if you could address ryu's last review when you have time! |
I translated changes in 1348bff. |
Hi @anmoti 👋 No rush at all. just checking in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jp-knj.
Sorry, did not check CI.
Fixed the link issue and also fixed the missing link issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Amazing work 💜
Description (required)
Apply ad30681 to the Japanese version.
Related issues & labels (optional)
i18n