-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix: Correctly mark Astro.glob as deprecated #14866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correctly mark Astro.glob as deprecated #14866
Conversation
When using overloads, each overload has to be marked as deprecated separately, to be correctly identified by editors, such as VS Code
🦋 Changeset detectedLatest commit: 18b8b86 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14866 will not alter performanceComparing Summary
Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :) Please just add a changeset if possible!
Co-authored-by: Florian Lefebvre <[email protected]>
florian-lefebvre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Changes
Correctly mark Astro.glob as deprecated.
When using overloads, each overload has to be marked as deprecated separately to be correctly identified by editors, such as VS Code.
It now correctly shows as deprecated for all overload signatures.
Before:
After:
Testing
N/A
Docs
N/A