Skip to content

Conversation

@matthewp
Copy link
Contributor

@matthewp matthewp commented Nov 21, 2025

Changes

  • This fixes a variety of issues that were breaking tests. I commented inline where it felt appropriate. Explanations for individual fixes are in the commit messages which are linked individually, below.

Testing

  • test/ssr-manifest.test.js - 4578d2d
  • test/content-collections.test.js - 5fd8edf
  • test/config-vite.test.js - 9c3aa38
  • test/entry-file-names.test.js - 4509536
  • test/redirects.test.js - 11ab96e
  • test/server-islands.test.js - 15fc25e
  • test/css-inline-stylesheets.test.js - 8897c3e
  • test/css-import-as-inline.test.js - de91192
  • test/vitest.test.js - d5b6a76
  • test/serializeManifest.test.js - 7794452
  • test/ssr-dynamic.test.js - 59cd518
  • test/core-image-unconventional-settings.test.js - ce5ed6b
  • test/0-css.test.js - ad982c6
  • test/astro-global.test.js - 732cfaf
  • test/content-collections.test.js - 1bedc36

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025

🦋 Changeset detected

Latest commit: fdf0670

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 21, 2025
If the module with the server island mapping is in a chunk, need to use
a parent-relative import statement to reach the server island module
itself.
Properly handle isDev in the virtual module
Prod now matches dev, we default to adding a trailing slash to the
Astro.request.url. Improves an annoying dev/build different in Astro 5.
Propagated styles get embedded in the JS and rendered at runtime if they
are used on a page. These need to include the base, which this change
makes happen.
@matthewp matthewp marked this pull request as ready for review November 22, 2025 22:07
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as far as I can tell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants