-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fixes for tests in environment branch #14865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewp
wants to merge
22
commits into
feat/environment-api
Choose a base branch
from
tests/various-fixes-2
base: feat/environment-api
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+338
−347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fdf0670 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
If the module with the server island mapping is in a chunk, need to use a parent-relative import statement to reach the server island module itself.
Properly handle isDev in the virtual module
Prod now matches dev, we default to adding a trailing slash to the Astro.request.url. Improves an annoying dev/build different in Astro 5.
Propagated styles get embedded in the JS and rendered at runtime if they are used on a page. These need to include the base, which this change makes happen.
Princesseuh
approved these changes
Nov 23, 2025
Member
Princesseuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great as far as I can tell!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
test/ssr-manifest.test.js- 4578d2dtest/content-collections.test.js- 5fd8edftest/config-vite.test.js- 9c3aa38test/entry-file-names.test.js- 4509536test/redirects.test.js- 11ab96etest/server-islands.test.js- 15fc25etest/css-inline-stylesheets.test.js- 8897c3etest/css-import-as-inline.test.js- de91192test/vitest.test.js- d5b6a76test/serializeManifest.test.js- 7794452test/ssr-dynamic.test.js- 59cd518test/core-image-unconventional-settings.test.js- ce5ed6btest/0-css.test.js- ad982c6test/astro-global.test.js- 732cfaftest/content-collections.test.js- 1bedc36Docs
N/A, bug fix