Skip to content

Conversation

@trueberryless
Copy link
Contributor

Changes

  • Refactor public API of actions to reduce what is exported

    I think I missed a lot of refactorings needed. I just wanted to get the ball rolling and get some feedback on what I am doing right and wrong in this codebase. I think if I understand what to do once, I could apply it better to all necessary refactorings. Feel free to let me know if explaining the changes would take more time than it’s worth. I’m happy for you to handle them if that’s easier, and I can pick up something else afterward — no worries at all. I’d just be really happy to start contributing and become more helpful over time.

  • Cleanup additional internals regarding actions

  • Closes Cleanup actions public API #14608

Testing

I did not change any tests, as I think that these refactorings do not need new tests. Please let me know if I should add tests and if so, in which file(s)!
Unfortunately, I was unable to run tests locally.

Docs

No docs changed, this PR is intended to just refactor internal exports and remove public access to some types.
The docs were already adapted in withastro/docs#12596

Todo

  • Write a proper changeset with breaking changes once I understand what I actually need to do 😅

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: f4cdd0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

CodSpeed Performance Report

Merging #14844 will not alter performance

Comparing trueberryless:refactor/tbl-14608-cleanup-actions-public-api (283ea2e) with main (78ed8b5)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (e878679) during the generation of this report, so 78ed8b5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@florian-lefebvre
Copy link
Member

First of all, the PR should be against the next branch!

@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Nov 21, 2025
@trueberryless trueberryless changed the base branch from main to next November 22, 2025 07:02
@trueberryless
Copy link
Contributor Author

First of all, the PR should be against the next branch!

I'm gonna do it better next time 😅

@florian-lefebvre
Copy link
Member

Do you need help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup actions public API

2 participants