-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Cleanup public actions API #14844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Cleanup public actions API #14844
Conversation
|
CodSpeed Performance ReportMerging #14844 will not alter performanceComparing Summary
Footnotes |
|
First of all, the PR should be against the next branch! |
I'm gonna do it better next time 😅 |
|
Do you need help? |
Changes
Refactor public API of actions to reduce what is exported
I think I missed a lot of refactorings needed. I just wanted to get the ball rolling and get some feedback on what I am doing right and wrong in this codebase. I think if I understand what to do once, I could apply it better to all necessary refactorings. Feel free to let me know if explaining the changes would take more time than it’s worth. I’m happy for you to handle them if that’s easier, and I can pick up something else afterward — no worries at all. I’d just be really happy to start contributing and become more helpful over time.
Cleanup additional internals regarding actions
Closes Cleanup actions public API #14608
Testing
I did not change any tests, as I think that these refactorings do not need new tests. Please let me know if I should add tests and if so, in which file(s)!
Unfortunately, I was unable to run tests locally.
Docs
No docs changed, this PR is intended to just refactor internal exports and remove public access to some types.
The docs were already adapted in withastro/docs#12596
Todo