Skip to content

Conversation

@ghostdevv
Copy link
Contributor

Changes

Tries to potentially address #14766 by using the aliases from tsconfig.

I personally had an issue with #14590 because I use an alias with $ rather than the astro convention of @. I figured that one option to fix this is to utilise the resolution from the astro:tsconfig-alias plugin.

Now this does work currently, IF you're using this alias feature (i.e. not using vite replacements) AND you don't include a baseUrl in your tsconfig. Since the base url changes how relative paths are resolved, it would actually circumvent the changes made in #14766 since foo.png, for example, would match the base url regex.

I need a break, but will look into this a little more later and hopefully figure out why the markdown resolution is working fine. Putting this up now though in case anyone else has any insight.

Testing

Tests have been added and need some further work

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 067e18a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

CodSpeed Performance Report

Merging #14843 will not alter performance

Comparing ghostdevv:content-image-resolution (067e18a) with main (78ed8b5)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (e878679) during the generation of this report, so 78ed8b5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant