-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(deps): update @sveltejs/vite-plugin-svelte to v6
#14821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 809e318 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 Changeset Validation Results❌ Changeset validation failed Issues Found:
|
|
The HMR testing is failing. It seems that It might be best for this PR to wait until #14306 is merged into |
Changes
Updates
@sveltejs/vite-plugin-svelteinpackage.jsonfrom v5 to v6@sveltejs/[email protected]drops support for Node v18 and requires Node v20.19+. This is the same requirement as the upcoming astro v6.Check this link for the full changelog of
@sveltejs/[email protected]:Ignores modules IDs with
\0vite-plugin-svelte v5 used to use
createFilterfromrollupto match Svelte files.createFilterincludes all IDs with\0at createFilter.ts#L51. This ensures that all virtual modules with an ID starting with\0astro-entry:won't be matched.vite-plugin-svelte v6 uses Vite's new object hook syntax for matching and simply matches all IDs ending with
.svelte.This change causes the following errors:
I fixed this issue by excluding all modules with
\0.Testing
Update some package.json files of the integration tests so that they will use the local build of
@astrojs/svelte.Docs
See changeset.