-
-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(cloudflare): eliminate duplicate import warnings during build #14777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudflare): eliminate duplicate import warnings during build #14777
Conversation
Removes the repeated definitions of matchHostname, matchPathname, matchProtocol, matchPort and matchPattern that are already provided by the @astrojs/internal-helpers/remote package. This resolves the build warning about unused external imports and avoids maintaining the same logic in multiple places by relying on the shared helpers. Closes withastro#14752
🦋 Changeset detectedLatest commit: 88d3e0c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
florian-lefebvre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This doesn't solve the linked issue but it's a good improvement
Description
Changes
Before:
After:
Testing
Documentation
No documentation updates are required because this is an internal refactor that: