Fix dev-web 404 and strengthen CI content check - #442
Merged
Conversation
custom.webpack.config.js: add devServer.contentBase pointing to web/src/main/js so webpack-dev-server always finds index.html and other static assets even on a fresh checkout (before any prior build). scripts/test-dev-web.sh: in addition to checking HTTP 200, verify the response body contains the app bundle reference and that the bundle itself is reachable — prevents the script from passing on a transient server startup page. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Serving index.html from src/main/js/ is incorrect: the compiled Scala.js bundle lives in the webpack output (target/), not the source tree. The actual 404 issue was caused by the @webpack-cli/serve crash already fixed in master. The only needed fix here is the CI content check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/test-dev-web.sh: in addition to checking HTTP 200, verify
the response body contains the app bundle reference and that the
bundle itself is reachable — prevents the script from passing on a
transient server startup page.