Open
Conversation
This was referenced Mar 12, 2025
|
looking forward to see this merged in a new release, what's missing to get this merged? |
Author
|
I wait for a review of @17o2 or @kvid , but I fully understand that they do not have an enormous amount of time and that this has a rather large amount of code changes. I also see possible improvements but have other things that are more important to do/ want to do. Such things are,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying an hour to resove the conflicts in #412 I decided to just "reimplement" it based on a new branch based on the current dev branch.
@SnowMB Thanks for your work in #412
I will now close all the other old MRs