Skip to content

feat: add team management access from main navigation (WPB-17721) #4092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 2, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jun 30, 2025

StoryWPB-17721 [Android] Add link to Team Management (TM) in main menu for admins and team owners


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Add from the main app drawer the navigation to team management
  • Add external link indicator to items that they are
  • This navigation is available for admins and team owners only

How to Test

  • Login the app, as an admin or owner, see the link to team management (TM)
  • Login as a regular user, you should not see a link to TM

Attachments (Optional)

Screen_recording_20250630_154354.webm

Screenshot 2025-06-30 at 15 45 14


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.73%. Comparing base (f285b14) to head (1eae9c9).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 92.10% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4092      +/-   ##
===========================================
- Coverage    47.75%   47.73%   -0.02%     
===========================================
  Files          502      502              
  Lines        17582    17649      +67     
  Branches      2899     2909      +10     
===========================================
+ Hits          8396     8425      +29     
- Misses        8306     8341      +35     
- Partials       880      883       +3     
Files with missing lines Coverage Δ
...com/wire/android/ui/home/drawer/HomeDrawerState.kt 100.00% <100.00%> (ø)
...wire/android/ui/home/drawer/HomeDrawerViewModel.kt 93.18% <92.10%> (-6.82%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f285b14...1eae9c9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Built wire-android-staging-compat-pr-4092.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4092.apk is available for download

@yamilmedina yamilmedina closed this Jul 1, 2025
@yamilmedina yamilmedina reopened this Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Built wire-android-staging-compat-pr-4092.apk is available for download

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Built wire-android-dev-debug-pr-4092.apk is available for download

Copy link

sonarqubecloud bot commented Jul 2, 2025

@yamilmedina yamilmedina enabled auto-merge July 2, 2025 16:28
@yamilmedina yamilmedina added this pull request to the merge queue Jul 2, 2025
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Built wire-android-staging-compat-pr-4092.apk is available for download

Merged via the queue into develop with commit 6d74cf2 Jul 2, 2025
12 of 13 checks passed
@yamilmedina yamilmedina deleted the feat/tm-access-improve branch July 2, 2025 17:07
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Built wire-android-dev-debug-pr-4092.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants