Skip to content

feat: history options screens when creating new channel [WPB-15877] #4090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jun 27, 2025

StoryWPB-15877 [Android] Start a new Channel - Create a new Channel - Channel history


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

New option when creating a channel to select a history duration.
Two screens - one to select one of predefined values and second one to choose any custom one.

channel_history_options.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 7.40741% with 25 lines in your changes missing coverage. Please review.

Project coverage is 47.68%. Comparing base (7119fe2) to head (1dfa28c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...wconversation/channelhistory/ChannelHistoryType.kt 0.00% 19 Missing ⚠️
...rsation/channelhistory/ChannelHistoryCustomArgs.kt 0.00% 4 Missing ⚠️
...ns/details/options/GroupConversationOptionsItem.kt 0.00% 1 Missing ⚠️
...i/home/newconversation/NewConversationViewModel.kt 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (7.40%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4090      +/-   ##
===========================================
- Coverage    47.75%   47.68%   -0.07%     
===========================================
  Files          502      504       +2     
  Lines        17582    17606      +24     
  Branches      2899     2899              
===========================================
  Hits          8396     8396              
- Misses        8306     8330      +24     
  Partials       880      880              
Files with missing lines Coverage Δ
...newconversation/channelaccess/ChannelAccessType.kt 37.50% <100.00%> (ø)
...ersation/channelaccess/ChannelAddPermissionType.kt 60.00% <100.00%> (ø)
...ns/details/options/GroupConversationOptionsItem.kt 0.00% <0.00%> (ø)
...i/home/newconversation/NewConversationViewModel.kt 61.04% <0.00%> (-0.36%) ⬇️
...rsation/channelhistory/ChannelHistoryCustomArgs.kt 0.00% <0.00%> (ø)
...wconversation/channelhistory/ChannelHistoryType.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7119fe2...1dfa28c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copy link
Contributor

Built wire-android-staging-compat-pr-4090.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-4090.apk is available for download

@saleniuk saleniuk requested review from vitorhugods, a team, sbakhtiarov, yamilmedina, alexandreferris and MohamadJaara and removed request for a team June 30, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant