Skip to content

fix(process): refuse to start a second session process for one id #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xepozz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(process): refuse to start a second session process for one id #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/process/session.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,16 @@ local function run(args: SessionArgs)
public_meta = session_data.public_meta,
})

process.registry.register("session." .. args.session_id)
-- The registered name is what makes a session single. Ignoring the result
-- let a second process start under the same id and drive the same session:
-- both hold their own writer, both append to the same conversation, and the
-- one that lost the race keeps answering on a name that no longer routes to
-- it. Callers cannot prevent this on their own -- the relay plugin, for
-- one, checks only its own map before spawning -- so the guard belongs here.
local registered, register_err = process.registry.register("session." .. args.session_id)
if not registered then
error("Session " .. tostring(args.session_id) .. " is already running: " .. tostring(register_err))
end

local session_state = {
stopping = false,
Expand Down