-
Notifications
You must be signed in to change notification settings - Fork 854
feat: add query arg for oidc expiration #7312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| c559aa1896dafc98a5000ce1a77bd28a9e087363 | ||
| 0d72102809e766d5285a162dcc30055847700ee2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -945,13 +945,15 @@ export function getResumeEndpoints(approver?: string): Promise<{ | |
| /** | ||
| * Get an OIDC jwt token for auth to external services (e.g: Vault, AWS) (ee only) | ||
| * @param audience audience of the token | ||
| * @param expiresIn Optional number of seconds until the token expires | ||
| * @returns jwt token | ||
| */ | ||
| export async function getIdToken(audience: string): Promise<string> { | ||
| export async function getIdToken(audience: string, expiresIn?: number): Promise<string> { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good addition of the JSDoc comment for the new parameter! One minor consistency note: The Python client uses |
||
| const workspace = getWorkspace(); | ||
| return await OidcService.getOidcToken({ | ||
| workspace, | ||
| audience, | ||
| expiresIn, | ||
| }); | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.