Skip to content

Conversation

@willemt
Copy link
Owner

@willemt willemt commented Apr 28, 2025

No description provided.

@willemt willemt requested a review from Copilot April 28, 2025 22:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the test execution flow to introduce an early return when operating in collect-only mode.

  • Introduces an early return if previous_collectonly is truthy
  • Removes the explicit invocation of _run_test_loop for non-collectonly mode
Comments suppressed due to low confidence (1)

pytest_asyncio_cooperative/plugin.py:312

  • The early return for collectonly mode is now in place, but the removal of the _run_test_loop invocation means that when previous_collectonly is false, the cooperative test loop is never executed. Please verify that this change is intentional and that tests still run as expected in non-collectonly mode.
if previous_collectonly:

@willemt willemt force-pushed the refac-flatten-indentation branch from aec4cab to dc18674 Compare April 28, 2025 22:49
@willemt willemt merged commit 80f89a1 into master Apr 28, 2025
6 checks passed
@willemt willemt deleted the refac-flatten-indentation branch April 28, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants