Skip to content

Update README.md#1

Open
willglas wants to merge 1 commit intomainfrom
willglas-patch-1
Open

Update README.md#1
willglas wants to merge 1 commit intomainfrom
willglas-patch-1

Conversation

@willglas
Copy link
Copy Markdown
Collaborator

Reviewers: Please read this description carefully. By approving this pull request you are approving its deployment and mitigation plans as well as the code change. If you feel there is anything unclear or missing, please ask for updates.

Issues affected by this change

What are you trying to accomplish?

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Which environments does this change target?

  • Production
    • dotcom
    • proxima
    • GHES
    • GHAE
  • Non-production
    • dev/test
    • docs

Risk Assessment

  • Low risk the change is fully under one or more Feature Flags OR the modifications are small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users and not bring the site down.
  • High risk changes are those that could impact our customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Feature Flags

If something goes wrong, what are the mitigation and rollback strategies?

  • Unknown - I forgot to update this section and don't have a mitigation strategy.

  • Experiment - Change will be tested with an experiment, but will need to be rolled back if the experiment does not work. Please link to the relevant experiment below.
  • Solo Deploy - This change will be deployed solo, making it easier to monitor impact and revert if necessary. Solo deploys should be used sparingly since they prevent others from shipping with you.
  • Feature Flag - Change can be disabled by feature flag, but will need to be rolled back if the feature flag does not work. Please link to the relevant feature flags below.
  • Review Lab Deploy - This change will be tested on review-lab before being queued to deploy.
  • Rollback - Change can only be disabled by rolling back the merge group, or by deploying a revert commit.

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Observability

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dfsdaf

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Copy link
Copy Markdown
Collaborator

@williamglas williamglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

Comment thread README.md
@willglas willglas marked this pull request as draft June 6, 2024 18:03
@willglas willglas marked this pull request as ready for review June 6, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants