Avoid closure allocation in DataGridColumn.CoerceWidth#308
Open
MilanSteinbach wants to merge 1 commit into
Open
Avoid closure allocation in DataGridColumn.CoerceWidth#308MilanSteinbach wants to merge 1 commit into
MilanSteinbach wants to merge 1 commit into
Conversation
Owner
|
Self-review completed. I reviewed the complete one-file allocation change against master and found no actionable issues. This PR has no GitHub check runs, so I validated it locally: the full Avalonia.Controls.DataGrid.UnitTests suite passed 2,250/2,250 and git diff --check is clean. The PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents the allocation caused by capturing
targetinside ofCoerceWidth, which allocates 32 bytes every time the function is called, including early exits.This quickly adds up, as
CoerceWidthgets called multiple times per scroll, per column.Changes